Rescue Master Branch PR: ENH Stop using old deprecated allVersions call
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/1/rescue-master-deprecate-allversions
branch
from
7c846a6 to
e5e953f
Compare
emteknetnz
requested changes
Aug 29, 2022
|
Please read the PR description which explains the difference between this PR and the original which is rescued. |
emteknetnz
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescues f4259a1
Targetting 1 because
allVersions()is already deprecated and we don't want to be throwing deprecation warnings for core usage.I only kept the actual change of method used - the other changes from the original commit caused failures in tests.
Parent issue