MNT Remove TODO comments #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
7553837 to
7d98e9b
Compare
sabina-talipova
commented
Oct 19, 2023
| @@ -1301,7 +1299,6 @@ public function getTag() | |||
| */ | |||
| public function BackLinkTracking() | |||
| { | |||
| // @todo - Implement PolymorphicManyManyList to replace this | |||
There was a problem hiding this comment.
Open ticket: #575
sabina-talipova
commented
Oct 19, 2023
| @@ -711,8 +711,6 @@ protected function onBeforeWrite() | |||
| // This logic is also used in the Folder subclass, but we're querying | |||
| // for duplicates on the File base class here (including the Folder subclass). | |||
|
|
|||
| // TODO Add read lock to avoid other processes creating files with the same name | |||
| // before this process has a chance to persist in the database. | |||
There was a problem hiding this comment.
Open ticket: #578
sabina-talipova
commented
Oct 19, 2023
| @@ -27,7 +27,6 @@ | |||
| * (see http://doc.silverstripe.org/secure-development#filesystem). | |||
| * {@link File::$allowed_extensions} provides a good start for a list of "safe" extensions. | |||
| * | |||
| * @todo Allow for non-database uploads | |||
There was a problem hiding this comment.
Open ticket: #576
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
7d98e9b to
ae8d9ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue