Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix scss lint warnings #762

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli changed the base branch from 4 to 4.2 June 5, 2024 22:40
}

/* stylelint-disable max-nesting-depth */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lint rule is really intended to stop us getting into this situation in the first place - resolving this retroactively would require changing the specificity of the selectors used for styling which is not in scope for this card.

@GuySartorelli GuySartorelli marked this pull request as draft June 5, 2024 22:41
@GuySartorelli GuySartorelli marked this pull request as ready for review June 11, 2024 22:07
@emteknetnz emteknetnz merged commit db19db5 into silverstripe:4.2 Jun 11, 2024
12 checks passed
@emteknetnz emteknetnz deleted the pulls/4.2/scss-lint branch June 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants