FIX Replaced deprecated CSS and React functions #258

sabina-talipova · 2023-03-13T22:12:35Z

Description

Replaced deprecated React function componentWillReceiveProps with componentDidUpdate;
Replaced deprecated React function componentWillMount with componentDidMount;
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
- Replaced divider / to calc(*/*) function

Parent issue

Clear up errors and warnings when running yarn commands silverstripe-admin#1416

maxime-rainville

LGTM.

maxime-rainville · 2023-03-21T06:14:04Z

client/src/containers/CampaignAdmin/CampaignAdmin.js

@@ -59,20 +59,20 @@ class CampaignAdmin extends Component {
    this.handleToggleMessage = this.handleToggleMessage.bind(this);
  }



Tested this and it seems to be working fine.

FIX Replaced deprecated CSS and React functions

4cce0ff

sabina-talipova mentioned this pull request Mar 13, 2023

Clear up errors and warnings when running yarn commands silverstripe/silverstripe-admin#1416

Closed

2 tasks

maxime-rainville approved these changes Mar 21, 2023

View reviewed changes

maxime-rainville merged commit e0f29fc into silverstripe:2.0 Mar 24, 2023

maxime-rainville deleted the pulls/2.0/fix-frontend-warnings branch March 24, 2023 01:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX Replaced deprecated CSS and React functions #258

FIX Replaced deprecated CSS and React functions #258

sabina-talipova commented Mar 13, 2023

maxime-rainville left a comment

maxime-rainville Mar 21, 2023

		@@ -59,20 +59,20 @@ class CampaignAdmin extends Component {
		this.handleToggleMessage = this.handleToggleMessage.bind(this);
		}

FIX Replaced deprecated CSS and React functions #258

FIX Replaced deprecated CSS and React functions #258

Conversation

sabina-talipova commented Mar 13, 2023

Description

Parent issue

maxime-rainville left a comment

Choose a reason for hiding this comment

maxime-rainville Mar 21, 2023

Choose a reason for hiding this comment