add controller_name config var to SiteTree for easier override #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewandante
force-pushed
the
pulls/4/add_controller_name_config_var
branch
from
8464e28 to
1ac1ea7
Compare
|
Awesome work Andrew! I'm asking to get this documented in a wider context as well: silverstripe/developer-docs#32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can do this by overriding the
getControllerName()method but this feels more idiomatic. Means that you can more easily do things like put your controllers in aMySite\Controlnamespace and have your pages inMysite\Model. Additionally saves having to do the while loop if you don't have to - could be an aim to have this as required by 5.0 to reduce unnecessary cycles (and ✨ magic ✨ ).