MNT Remove TODO comments #2898
Merged
MNT Remove TODO comments #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 12, 2023
| @@ -80,8 +80,6 @@ | |||
| * This class creates a 2-frame layout - left-tree and right-form - to sit beneath the main | |||
| * admin menu. | |||
| * | |||
| * @todo Create some base classes to contain the generic functionality that will be replicated. | |||
| * | |||
There was a problem hiding this comment.
Open ticket: #2896
sabina-talipova
commented
Oct 12, 2023
sabina-talipova
commented
Oct 12, 2023
| @@ -303,8 +302,6 @@ public function Menu($level) | |||
| /** | |||
| * Returns the default log-in form. | |||
| * | |||
| * @todo Check if here should be returned just the default log-in form or | |||
| * all available log-in forms (also OpenID...) | |||
There was a problem hiding this comment.
Open ticket: #2897
sabina-talipova
commented
Oct 12, 2023
| @@ -1958,7 +1958,6 @@ public function getLiveURLSegment() | |||
| */ | |||
| public function BackLinkTracking() | |||
| { | |||
| // @todo - Implement PolymorphicManyManyList to replace this | |||
| $list = ArrayList::create(); | |||
There was a problem hiding this comment.
Open ticket: #2895
sabina-talipova
commented
Oct 12, 2023
code/Reports/BrokenFilesReport.php
Outdated
There was a problem hiding this comment.
For all todo: use NestedTitle(2), new ticket was created: #2894
sabina-talipova
commented
Oct 12, 2023
| /** | ||
| * @todo Test canAddChildren() | ||
| * @todo Test canCreate() | ||
| */ |
There was a problem hiding this comment.
New ticket: #2893
sabina-talipova
commented
Oct 12, 2023
sabina-talipova
force-pushed
the
pulls/5.1/remove-todo
branch
from
1ff55f8
to
c1eaaaa
Compare
sabina-talipova
commented
Oct 19, 2023
sabina-talipova
commented
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue