Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #2908

Merged
merged 1 commit into from
Dec 6, 2023
Merged

MNT Fix unit test #2908

merged 1 commit into from
Dec 6, 2023

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#169

CI broke because this PR was merged up from 4.13 #2825

@emteknetnz emteknetnz mentioned this pull request Dec 5, 2023
Closed
GuySartorelli
GuySartorelli requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs to target 5.1

@emteknetnz emteknetnz changed the base branch from 5 to 5.1 December 6, 2023 01:56
@emteknetnz
Copy link
Member Author

Retargetted 5.1

GuySartorelli
GuySartorelli approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 8ca2ade into silverstripe:5.1 Dec 6, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.1/fixtest branch December 6, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli