MNT Broken builds #1036
Merged
MNT Broken builds #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Jan 24, 2023
There was a problem hiding this comment.
This broke because of silverstripe/silverstripe-framework#10538
Use Controller::normaliseTrailingSlash() to protect against future config changes.
EDIT: While I do think what I've recommended is best practice, after an offline conversation I'll just merge this as-is. We can deal with best practices some time later.
GuySartorelli
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/659
Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/3990680546/jobs/6844618517#step:12:68
1) DNADesign\Elemental\Tests\BaseElementTest::testLinkWithDataObject with data set "element1" ('DNADesign\Elemental\Models\El...ontent', 'content1', '/test-elemental/#e1') Failed asserting that two strings are equal.Broken behat tests + js job will be fixed as part of https://github.com/silverstripeltd/product-issues/issues/644