ENH Render some buttons for blocks that can not be edited inline

[maxime-rainville]

Some block types can not be edited in an Elemental Area (e.g.: UserForm blocks). Current behaviour is to not render any actions for those blocks in the Elemental Area.

However some action still make sense in that context (e.g.: Duplicate, Archive, Unpublish).

This PR allows those extra actions to be displayed.

Parent issue

• Fixes Some of the "More Actions" should still show on non in-line editable blocks #512

[maxime-rainville]

Turns out we didn't the Context provider non-sense at all. We just needed to pass the expandable prop all the way down.

[emteknetnz]

Tested locally, does what it should do. Unpublish button remains on elemental-userforms which makes sense IMO. Some minor changes requested

[emteknetnz]

should so the conditional check on this.props.expandable within renderEditTabs() and renderDivider() rather then here. Both those methods do conditional early returns on props

[emteknetnz]

@maxime-rainville remember to do this one

[maxime-rainville]

I swap the return null and return DropdownItem around just so the approach between renderDivider and renderTabs are consistien

[maxime-rainville]

I was thinking it might be nice to cover this behavior with some behat test, but we can't really do it without requiring userform and the userfrom block because that's the only block that can't be rendered inline.

[GuySartorelli]

we can't really do it without requiring userform and the userfrom block because that's the only block that can't be rendered inline.

I haven't done anything with behat tests yet so excuse my ignorance but I take it then that behat tests can't take advantage of classes that implement TestOnly?
Or temporary config changes for that matter? Since whether a block renders inline or not is controlled by config, if you could change that config for the duration of the test on say the content block, that would allow such a test to work.

[maxime-rainville]

I haven't done anything with behat tests yet so excuse my ignorance but I take it then that behat tests can't take advantage of classes that implement TestOnly?

@GuySartorelli Exactly ... your behat test need to be run against an actual functional website. Occasionally, we'll install frameworktest so we can test specific features that are not directly used in our core modules.

[emteknetnz]

@GuySartorelli example behat equivalent of a TestOnly page - https://github.com/silverstripe/silverstripe-frameworktest/blob/4/code/multitab-validation/MultiTabPage.php

It's a kind of janky solution having to include frameworktest given that moudles intended use is different (generating lots of dumy pages and dataobjects), though it practice it's good enough for our needs