FIX getOwnerPage() should respect Versioned state. #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this getOwnerPage() would always return the Draft versioned record. This would lead to cases were if a parent page contained draft changes, unauthenicated users would be blocked from viewing content blocks as `$this->getOwnerPage()->canView($member);` would fail since logged out users could not view pages with draft changes.
kinglozzer
approved these changes
Apr 14, 2022
GuySartorelli
previously requested changes
Apr 21, 2022
GuySartorelli
approved these changes
May 30, 2022
|
Hi there, Just wondering when this will be included in a tagged version of 4.x branch? We have a site that often experiences this issue so would really like to resolve this issue. |
|
There's nothing stopping this from being released as a patch other than that it was targetting |
menno-rdmkr
pushed a commit
to busting-bytes/silverstripe-elemental
that referenced
this pull request
Dec 15, 2022
…wner FIX getOwnerPage() should respect Versioned state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this getOwnerPage() would always return the Draft versioned
record. This would lead to cases were if a parent page contained draft
changes, unauthenicated users would be blocked from viewing content
blocks as
$this->getOwnerPage()->canView($member);would fail sincelogged out users could not view pages with draft changes.