FIX Use PreviewLink of the owner object to preview blocks #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
Could you add testing for PreviewLink, please. |
|
Just minor changes. Nice to have this enhancement! |
GuySartorelli
force-pushed
the
pulls/4.9/allow-empty-preview
branch
2 times, most recently
from
3910b4e to
5b78735
Compare
GuySartorelli
force-pushed
the
pulls/4.9/allow-empty-preview
branch
from
5b78735 to
24f6cde
Compare
menno-rdmkr
pushed a commit
to busting-bytes/silverstripe-elemental
that referenced
this pull request
Dec 15, 2022
…/allow-empty-preview Issue was solved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#871 allows
ElementalAreato be added to any arbitraryDataObject. We should always try to set the correct preview link where possible. SomeDataObjects may have aPreviewLinkmethod for preview in the CMS, but no front-end link.Finally, we should fallback to returning a null value if no link could be obtained for preview, so that the preview panel can correctly display a "no preview available" message.
Parent Issues
Related