Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #30

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dispatch/EventDispatcherInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ public function removeListener(string $eventName, EventHandlerInterface $listene
* @param object $eventContext
* @param string|null $eventName
*/
public function dispatch(object $eventContext, string $eventName = null): void;
public function dispatch(object $eventContext, ?string $eventName = null): void;
}
2 changes: 1 addition & 1 deletion src/Symfony/Event.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Event implements EventContextInterface
* @param string $action
* @param array $properties
*/
public function __construct(string $action = null, array $properties = [])
public function __construct(?string $action = null, array $properties = [])
{
$this->event = new GenericEvent($action, $properties);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Dispatch/MockBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class MockBackend implements EventDispatcherInterface

public $listeners = [];

public function dispatch(object $eventContext, string $eventName = null): void
public function dispatch(object $eventContext, ?string $eventName = null): void
{
$listeners = $this->listeners[$eventName] ?? [];
foreach ($listeners as $listener) {
Expand Down