Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 Tidy up #10294

Closed
19 tasks done
emteknetnz opened this issue Apr 27, 2022 · 2 comments
Closed
19 tasks done

PHP 8.1 Tidy up #10294

emteknetnz opened this issue Apr 27, 2022 · 2 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Apr 27, 2022

Parent issue for pull-requests to tidy up PHP 8.1 work

TODO

  • Get tractorcow/classproxy - need either a 0.1.3 tag OR proxy-db to use ^1 - see linked PR below. If we update proxy-db, also need pull-requests to update silverstripe/auditor and silverstripe/fulltextsearch which both require proxy-db
  • Ensure silverstripe/recipe-solr-search requires 3.10.x-dev of fulltextsearch (should happen automatically as part of cow release)
  • https://app.travis-ci.com/github/silverstripe/silverstripe-installer/jobs/568330265#L1305 (fixed in graphql PR below)

Notes on trying to get travis ci to fail on deprecations:

Depite this PR - we still have green jobs with deprecation warnings

I don't think we can get phpunit to properly fail on deprecation notices - I've tried the following custom error handler in SapphireTest.php along with --fail-on-warning

set_error_handler(function (int $number, string $message) {
    trigger_error($message, E_USER_WARNING);
}, E_DEPRECATED | E_USER_DEPRECATED);

However tests are still green despite the presence of Warning: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated

I've also tried updating phpunit.xml.dist - https://phpunit.readthedocs.io/en/9.5/configuration.html - however failOnWarning="true" which is equally useless as --fail-on-warning and convertDeprecationsToExceptions="true" is too brutal and causes phpunit to exit

PRs

@emteknetnz emteknetnz self-assigned this Apr 27, 2022
@emteknetnz emteknetnz removed their assignment Apr 28, 2022
@emteknetnz emteknetnz removed their assignment May 2, 2022
@GuySartorelli
Copy link
Member

PRs are merged, but there is an acceptance criterion that can't be ticked off until the cow beta release either does or does not update composer.json in recipe-solr-search.

@GuySartorelli
Copy link
Member

recipe-solr-search is correct in 4.11. All acceptance criteria met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants