MNT Disallow failures on php 8.1 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
| @@ -25,6 +25,3 @@ jobs: | |||
| - DB=MYSQL | |||
| - REQUIRE_INSTALLER="4.x-dev" | |||
| - PHPUNIT_TEST=1 | |||
| - COMPOSER_INSTALL_ARG=--ignore-platform-reqs | |||
There was a problem hiding this comment.
Did you mean to remove this line as well? If so, can you explain what the intention is there?
There was a problem hiding this comment.
Yup, originally we needed that line when things weren't installable due to the not being php compatible. Things are compatible now so we no longer need it
GuySartorelli
approved these changes
May 2, 2022
|
Approved, but I don't have access to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10294