Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove GraphQL #11316

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Forms/FormRequestHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public function __construct(Form $form)
public function Link($action = null)
{
// Forms without parent controller have no link;
// E.g. Submission handled via graphql
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
$controller = $this->form->getController();
if (empty($controller)) {
return null;
Expand Down
11 changes: 11 additions & 0 deletions src/Forms/GridField/GridField.php
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ class GridField extends FormField
*/
protected $readonlyComponents = [];

/**
* Intentionally not set to FormField::SCHEMA_DATA_TYPE_STRUCTURAL even though there is no corresponding
* react component because we want a hard exception thrown for devleopers to see rather than have
* them wonder why the field is not rendering.
*
* Marked as @interal to allow change in a minor release as a react GridField may be implemented in the future
*
* @internal
*/
protected $schemaDataType;

/**
* Pattern used for looking up
*/
Expand Down
2 changes: 1 addition & 1 deletion src/ORM/Connect/NullDatabase.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* Utility class required due to bad coupling in framework.
* Not every framework execution should require a working database connection.
* For example, when generating class and config manifests for deployment bundles,
* For example, when generating class and config manifests for deployment bundles
* or when generating code in a silverstripe/graphql schema build.
*
* This class creates the required no-ops to fulfill the contract,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ public function testRedirectTrailingSlashIgnorePaths(bool $addTrailingSlash, boo
$requestSlash = $requestHasSlash ? '/' : '';
$noRedirectPaths = [
"/admin{$requestSlash}",
"/admin/graphql{$requestSlash}",
"/dev/tasks/my-task{$requestSlash}",
];
$allowRedirectPaths = [
Expand Down
Loading