API Make validator param nullable #11512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6.0/broken-builds
branch
from
8cce5b7 to
bfe6f94
Compare
emteknetnz
commented
Dec 16, 2024
| @@ -303,9 +303,9 @@ public function testTreeSearchUsingSubObject() | |||
| $cssPath = 'ul.tree li#selector-TestTree-' . $subObject1->ID . ' li#selector-TestTree-' . $subObject1ChildB->ID . ' a'; | |||
| $firstResult = $parser->getBySelector($cssPath); | |||
| $this->assertEquals( | |||
| $subObject1ChildB->Name, | |||
| $subObject1ChildB->Title, | |||
There was a problem hiding this comment.
I think this test used to pass by accident. The fixtures in TreeDropdownFieldTest.yml have a Title property, not a Name property
There was a problem hiding this comment.
It would be interesting to know what we changed that stopped that from working, but you're right that it shouldn't have been.
emteknetnz
commented
Dec 16, 2024
| * @return $this | ||
| */ | ||
| public function setValidator(Validator $validator) | ||
| public function setValidator(?Validator $validator) |
There was a problem hiding this comment.
Makes sense to have this param nullable, as there is no default and you should be able to 'unset' any existing validators, as there is no longer a need to always have a validator now that the Form will loop form fields and call validate() on them
GuySartorelli
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#349
Two commits
API commit Fixes
TypeError: SilverStripe\Forms\Form::setValidator(): Argument 1 ($validator) must be of type SilverStripe\Forms\Validation\Validator, null given, called in /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/silverstripe/framework/tests/php/Forms/GridField/GridFieldTest.php on line 554
MNT commit fixes
The data provider specified for SilverStripe\Forms\Tests\DropdownFieldTest::testGetDefaultValue is invalid
Data Provider method SilverStripe\Forms\Tests\DropdownFieldTest::provideGetDefaultValue() is not static
and
is found, nested under
Failed asserting that 'Child B of Four SubObject' matches expected null.