API: Preserve variable types in template lookup args (closes #4822) #8152
Conversation
src/View/SSTemplateParser.peg
Outdated
|
|
||
| # Integers and floats | ||
|
|
||
| IntOrFloat: / (\d+(\.\d+)?) / |
There was a problem hiding this comment.
Doh. This needs to be updated to support passing things like .5, -10 etc. There are other expressions that are valid numbers in PHP (exponents, hexadecimal, binary), not sure if the effort/reward will be worth it for those - I’ll look into it
kinglozzer
changed the title
kinglozzer
force-pushed
the
template-types
branch
from
e8a4ebc to
c11bea9
Compare
kinglozzer
force-pushed
the
template-types
branch
from
c11bea9 to
eab37c8
Compare
| @@ -286,7 +286,8 @@ class SSTemplateParser extends Parser implements TemplateParser | |||
|
|
|||
| $property = $sub['Call']['Method']['text']; | |||
|
|
|||
| if (isset($sub['Call']['CallArguments']) && $arguments = $sub['Call']['CallArguments']['php']) { | |||
| if (isset($sub['Call']['CallArguments']) && isset($sub['Call']['CallArguments']['php'])) { | |||
| $arguments = $sub['Call']['CallArguments']['php']; | |||
There was a problem hiding this comment.
Change required as sometimes the arguments might simply be an int 0 or boolean false
| @@ -412,7 +412,7 @@ public function renderWith($template, $customFields = null) | |||
| protected function objCacheName($fieldName, $arguments) | |||
| { | |||
| return $arguments | |||
| ? $fieldName . ":" . implode(',', $arguments) | |||
| ? $fieldName . ":" . var_export($arguments, true) | |||
There was a problem hiding this comment.
Required as we can now pass actual booleans as arguments. Implode will cast false to an empty string, which would mean the same cache name between $Foo and $Foo(false)
kinglozzer
changed the title
|
wow - this is cool, I love it. So if you now want the string "true" it needs to be quoted in the template, right? I guess there's a distinction between One other feature I'd like to see is the template throwing warnings or errors if there's some kind of unquoted string - would that be much work? |
Correct on both counts
I think that should be pretty simple, we could trigger a deprecation notice or something. The counter argument is that as long as it’s not blocking any new features we want to add, why bother removing support for it? I personally prefer to be explicit about strings (and the same with remembering the |
|
I guess I like the idea of being able to define a strict template syntax and it feels like that's the way we are heading anyway... |
|
@kinglozzer do you want to be the new ss template engine sage? Because that's what it sounds like. ;) Somewhere a snowy mountain top is awaiting your presence. |
|
|
No description provided.