Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Undefined Exception on makeDir method #95

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ssmarco
Copy link

@ssmarco ssmarco commented Jan 16, 2024

This is a small fix that was caught by my editor's Intelephense package. Error is undefined type Silverstripe/GridfieldQueuedExport/Jobs/Exception

Description

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

This is a small fix that was caught by my editor's Intelephense package. Error is undefined type `Silverstripe/GridfieldQueuedExport/Jobs/Exception`
@GuySartorelli
Copy link
Member

Hiya,

Thank you for this.
Since this is such a small change I'll let you off the hook this time - but in the future please fill out all of the information in the PR description template, check all of the boxes that apply, and create an issue for your PR. This is all outlined in the contribution documentation and there are relevant links right there in the template for your reference.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when CI goes green.

@GuySartorelli GuySartorelli merged commit 14efc7b into silverstripe:3 Jan 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants