API Deprecate API that will be removed #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
requested changes
Sep 12, 2024
src/Tasks/LDAPGroupSyncTask.php
Outdated
| */ | ||
| protected function log($message) | ||
| { | ||
| Deprecation::notice('2.3.0', 'Will be removed without equivalent functionality to replace it'); |
There was a problem hiding this comment.
Wrap this in withNoReplacement() rather than all the things calling it
Do this in this PR and all other CMS 5 PRs linked in the parent issue
There was a problem hiding this comment.
Wrap this in withNoReplacement() rather than all the things calling it
As discussed in person it's more appropriate to wrap the things calling it, so that developers calling it from their own code get an appropriate deprecation warning.
GuySartorelli
force-pushed
the
pulls/2/cms5-for-sakesymfony
branch
from
1f15e24
to
2d14162
Compare
emteknetnz
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #89
Issue