Don't call newClassInstance on link that haven't been saved yet.

silverstripe · Oct 28, 2020 · 6777e41 · 6777e41
1 parent be42b5b
commit 6777e41
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/Models/Link.php b/src/Models/Link.php
@@ -3,6 +3,7 @@
 namespace SilverStripe\Link\Models;
 
 use InvalidArgumentException;
+use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Link\JsonData;
 use SilverStripe\Link\Type\Registry;
@@ -84,7 +85,12 @@ function setData($data): JsonData
 
  $jsonData = $this;
  if ($this->ClassName !== get_class($type)) {
- $jsonData = $this->newClassInstance(get_class($type));
+ if ($this->isInDB()) {
+ $jsonData = $this->newClassInstance(get_class($type));
+ } else {
+ $jsonData = Injector::inst()->create(get_class($type));
+ }
+
  }
 
  foreach ($data as $key => $value) {