ENH Add localisation support #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/4/add-localization-support
branch
2 times, most recently
from
ce6d032 to
f47ae60
Compare
3 tasks
sabina-talipova
force-pushed
the
pulls/4/add-localization-support
branch
2 times, most recently
from
f00a449 to
76f6880
Compare
emteknetnz
requested changes
Nov 13, 2023
lang/en.yml
Outdated
| @@ -0,0 +1,34 @@ | |||
| en: | |||
| LinkField: | |||
| UPDATELINK: 'Update link' | |||
There was a problem hiding this comment.
There isn't a clear standard around translation keys. While uppercase without underscores is the most common, is also hard to read
Could you please put underscores in the keys e.g. UPDATE_LINK
src/Models/ExternalLink.php
Outdated
| @@ -15,6 +17,15 @@ class ExternalLink extends Link | |||
| 'ExternalUrl' => 'Varchar', | |||
| ]; | |||
|
|
|||
| public function getCMSFields(): FieldList | |||
| { | |||
| $this->beforeUpdateCMSFields(static function (FieldList $fields) { | |||
There was a problem hiding this comment.
Could you please change static function to just function for all of the anonymous methods in the getCMSFields for all of the subclasses on Link
sabina-talipova
force-pushed
the
pulls/4/add-localization-support
branch
from
76f6880 to
e129b28
Compare
emteknetnz
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added localisation support. All available messages, field names, etc. are updated and have the value set in the localisation file
Parent issue