Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Default link title for each link type #126

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/4/default-link-title branch 2 times, most recently from 6bd80b6 to 051f1da Compare December 1, 2023 01:43
@sabina-talipova sabina-talipova marked this pull request as ready for review December 3, 2023 19:23
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I haven't tested this locally or looked at the tests yet since there will be some fairly large implementation changes based on these requested changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
src/Models/SiteTreeLink.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/4/default-link-title branch 9 times, most recently from 1c61d8e to 3f7be08 Compare December 4, 2023 01:10
README.md Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
src/Models/EmailLink.php Outdated Show resolved Hide resolved
src/Models/ExternalLink.php Outdated Show resolved Hide resolved
src/Models/FileLink.php Outdated Show resolved Hide resolved
src/Models/FileLink.php Outdated Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
tests/php/Models/Extensions/ExternalLinkExtension.php Outdated Show resolved Hide resolved
tests/php/Models/LinkTest.php Outdated Show resolved Hide resolved
tests/php/Models/LinkTest.php Outdated Show resolved Hide resolved
tests/php/Models/LinkTest.php Show resolved Hide resolved
src/Models/Link.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/4/default-link-title branch from 3f7be08 to d1bfac8 Compare December 4, 2023 21:12
@sabina-talipova sabina-talipova force-pushed the pulls/4/default-link-title branch from d1bfac8 to 1e1083d Compare December 4, 2023 21:23
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works well locally. Does everything it should do.

@GuySartorelli GuySartorelli merged commit 436f45f into silverstripe:4 Dec 4, 2023
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/default-link-title branch December 4, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants