Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update PHPDoc for link models #136

Merged
merged 1 commit into from
Dec 5, 2023
Merged

DOC Update PHPDoc for link models #136

merged 1 commit into from
Dec 5, 2023

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Dec 5, 2023
Closed
GuySartorelli
GuySartorelli commented Dec 5, 2023
View reviewed changes
src/Models/Link.php
* A Link Data Object. This class should be a subclass, and you should never directly interact with a plain Link
* A Link Data Object. This class should be treated as abstract. You should never directly interact with a plain Link
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this language while I'm here to make it a little clearer. "This class should be a subclass" doesn't really make sense.

@emteknetnz emteknetnz merged commit 22fcdcc into silverstripe:4 Dec 5, 2023
10 checks passed
@emteknetnz emteknetnz deleted the pulls/4/phpdoc branch December 5, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz