ENH Add disabled field state #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sabina-talipova
suggested changes
Jan 25, 2024
There was a problem hiding this comment.
@emteknetnz, it looks like we should modify LinkFieldController::isReadOnlyField to check LinkField->isDisable(). Currently if we click on any disable link field we still can open modal window and edit link content.
emteknetnz
force-pushed
the
pulls/4/disabled
branch
from
8fe10c9
to
de7cc13
Compare
|
Updated |
emteknetnz
commented
Jan 25, 2024
emteknetnz
commented
Jan 25, 2024
sabina-talipova
suggested changes
Jan 25, 2024
emteknetnz
force-pushed
the
pulls/4/disabled
branch
from
de7cc13
to
4ba8267
Compare
sabina-talipova
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #181