Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Link field User manual #234

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Feb 20, 2024

Description

User guide. This manual consists of two main parts and a short introduction.

  • Part One: A quick guide to the default link types available.
  • Part two: A short guide on how to work with a link field.

Manual testing steps

Not required

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@sabina-talipova sabina-talipova force-pushed the pulls/4/user-docs branch 4 times, most recently from b9374a5 to e7aae89 Compare February 21, 2024 01:01
@sabina-talipova sabina-talipova marked this pull request as ready for review February 21, 2024 01:09
@sabina-talipova sabina-talipova force-pushed the pulls/4/user-docs branch 2 times, most recently from 7ee2798 to a4844b1 Compare February 21, 2024 01:31
docs/en/userguide/01_about_link_field.md Outdated Show resolved Hide resolved
docs/en/userguide/01_User_manual/01_links_types.md Outdated Show resolved Hide resolved
docs/en/userguide/01_about_link_field.md Outdated Show resolved Hide resolved
@sabina-talipova
Copy link
Contributor Author

Failed CI step is unrelated to this PR

docs/en/userguide/index.md Outdated Show resolved Hide resolved
docs/en/userguide/index.md Outdated Show resolved Hide resolved
docs/en/userguide/index.md Outdated Show resolved Hide resolved
docs/en/userguide/index.md Outdated Show resolved Hide resolved
docs/en/userguide/01_links_types.md Outdated Show resolved Hide resolved
docs/en/userguide/02_work_with_link_field.md Outdated Show resolved Hide resolved
docs/en/userguide/02_work_with_link_field.md Outdated Show resolved Hide resolved
docs/en/userguide/01_links_types.md Outdated Show resolved Hide resolved
docs/en/userguide/01_links_types.md Show resolved Hide resolved
docs/en/userguide/01_links_types.md Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ca1dd17 into silverstripe:4 Feb 22, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/user-docs branch February 22, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants