FIX Linkfield sorting issue #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/4/fix-sorting
branch
2 times, most recently
from
008ca5d to
afd0c7e
Compare
sabina-talipova
commented
Mar 26, 2024
sabina-talipova
force-pushed
the
pulls/4/fix-sorting
branch
from
afd0c7e to
8e8a47a
Compare
GuySartorelli
approved these changes
Mar 26, 2024
| $this->Sort = self::get()->filter([ | ||
| $this->Sort = Link::get()->filter([ |
There was a problem hiding this comment.
I think you may have found a bug in PHP itself! self always refers to the class where the code is declared, so these should be identical. But for some reason the late static binding inside the get() call is still bound to the specific subclass.
We should probably avoid calling static methods in general if this sort of thing is going to happen.
Nice find.
5 tasks
jareddreyerss
pushed a commit
to jareddreyerss/silverstripe-linkfield
that referenced
this pull request
Mar 28, 2024
…ix-sorting FIX Linkfield sorting issue
jareddreyerss
pushed a commit
to jareddreyerss/silverstripe-linkfield
that referenced
this pull request
Mar 28, 2024
…ix-sorting FIX Linkfield sorting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
self::get()method returns list of specific Link types, because of this for each link type we reset and begin to increaseSortagain.Parent issue