WIP: NEW Add a basic Behat test to set MFA to be required, and ensure "I log in as" skips MFA registration #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
changed the title
|
I need to look at the build failures, but will come back to it later. I can't reproduce them locally. |
NightJar
reviewed
Jun 25, 2019
NightJar
approved these changes
Jun 25, 2019
robbieaverill
force-pushed
the
pulls/4.0/behat-tests
branch
from
e85d2d2 to
3a097e2
Compare
… in as" skips MFA registration
robbieaverill
force-pushed
the
pulls/4.0/behat-tests
branch
from
3a097e2 to
f49b7ae
Compare
|
Will reopen this when it's working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to override the "I am logged in with X permissions" Behat context step to ensure it skips MFA registration. This is done in a class override, but all other modules with Behat tests that use this (all of them) will fail unless they are aware of MFA. This is a limitation we'll need to keep in mind when implementing CWP kitchen sink-wide Behat test runs.
Resolves #99