Add a basic behat test #226

robbieaverill · 2019-06-26T01:42:27Z

Resolves #99

Other changes lumped in:

Fix "do not redirect to MFA when there are no methods installed" logic, which was including backup codes in that check
Add a loading error component for when initial fetch of the schema fails on MFA app load (I think this was happening in Travis, but the screenshots showed a loading screen so it's hard to know - this component helps with that)
Replace btn-success with btn-primary for green colour consistency

…in as" skips MFA registration

…ption

…oad fails, implement for unavailable method screen

NightJar

Nice :)

client/src/components/LoadingError.js

robbieaverill added 3 commits June 26, 2019 11:23

NEW Add a basic Behat test to set MFA as required, and ensure "I log …

4e31e00

…in as" skips MFA registration

Update conditions for "wait until MFA has loaded"

546fa8a

FIX Do not redirect to MFA when backup codes are the only available o…

690b869

…ption

robbieaverill added affects/v4 change/minor labels Jun 26, 2019

Add loading error component for when fetching the schema on initial l…

7e7174a

…oad fails, implement for unavailable method screen

robbieaverill force-pushed the pulls/4.0/behat-tests branch from 3d00554 to 7e7174a Compare June 26, 2019 03:13

FIX Switch btn-success for btn-primary in MFA buttons

6f8e112

NightJar approved these changes Jun 26, 2019

View reviewed changes

ScopeyNZ reviewed Jun 26, 2019

View reviewed changes

client/src/components/LoadingError.js Outdated Show resolved Hide resolved

Move jsdoc to PropTypes

68a8323

ScopeyNZ approved these changes Jun 26, 2019

View reviewed changes

ScopeyNZ merged commit 2c3a076 into silverstripe:master Jun 26, 2019

ScopeyNZ deleted the pulls/4.0/behat-tests branch June 26, 2019 03:54

Provide feedback