DEP Upgrade frontend build stack #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jan 25, 2023
| import React from 'react'; | ||
|
|
||
| export default ({ color = 'currentColor', size = '3em' }) => ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" height={size} width={size}> | ||
| <g fill={color}> | ||
| {/* eslint-ignore-line max-len */} |
There was a problem hiding this comment.
This wasn't being picked up anymore
GuySartorelli
commented
Jan 25, 2023
Comment on lines
+300
to
+301
| case SCREEN_INTRODUCTION: | ||
| default: |
There was a problem hiding this comment.
default has to be the last case to pass linting
GuySartorelli
commented
Jan 25, 2023
Comment on lines
-71
to
+87
| ".*": "babel-jest" | ||
| ".[jt]s[mx]?$": "babel-jest" |
There was a problem hiding this comment.
Leaving this as .* resulted in babel thinking the json imports were meant to be javascript, and tests were failing for missing semicolons in the json data.
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
2 times, most recently
from
3e71d68 to
34962d8
Compare
GuySartorelli
force-pushed
the
pulls/5/frontend-build-stack
branch
from
34962d8 to
53c786e
Compare
emteknetnz
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1389 for a wider discussion on most of the changes
Parent issue