ENH Update translations #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Aug 21, 2023
|
That's understandable. We did a i18ntextcollector run in CMS 5, then pushed strings to transifex there, then pulled them here. |
|
That shouldn't result in there being English "translations" showing up for languages like French |
|
As discussed in person the problem is the english values being present in non-english locale files. Closing - a new PR with the correct translations will be generated next time we run tx-translator after fixing silverstripe/silverstripe-tx-translator#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated translations update generated using silverstripe/tx-translator