Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Upgrade installer dependencies #36

Conversation

sabina-talipova
Copy link

@sabina-talipova sabina-talipova commented Oct 26, 2022

Description

'Passing a command as string when creating a Process class instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell.'

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-installer-deps branch from 465d6b2 to 5e97405 Compare October 27, 2022 03:44
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GuySartorelli GuySartorelli merged commit 5d65afe into silverstripe:3 Oct 27, 2022
@GuySartorelli GuySartorelli deleted the pulls/3/upgrade-installer-deps branch October 27, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants