Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: SiteConfig should use getCMSCompositeValidator (fixes #131) #132

Merged
merged 1 commit into from
Nov 23, 2022
Merged

FIX: SiteConfig should use getCMSCompositeValidator (fixes #131) #132

merged 1 commit into from
Nov 23, 2022

Conversation

kinglozzer
Copy link
Member

@kinglozzer kinglozzer commented Nov 9, 2022 •
edited by GuySartorelli
Loading

@kinglozzer kinglozzer mentioned this pull request Nov 9, 2022
Closed
GuySartorelli
GuySartorelli reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please target 4? This is a change to behaviour so it feels like it should go in a minor release.

@kinglozzer kinglozzer changed the base branch from 4.11 to 4 November 23, 2022 09:53
@kinglozzer
Copy link
Member Author

Done, thankfully it doesn’t even need a rebase 😄

@GuySartorelli GuySartorelli merged commit fe45b01 into silverstripe:4 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinglozzer @GuySartorelli