PHP8 support. PHPUnit 9. Update Travis. Update test config

[chrispenny]

Fixes #135
Fixes #138

PHP Unit 9

Not too much had to update here. Just the usual missing : void declarations, and I needed to update some deprecated methods and assertContains to the new assetStringContainsString.

Travis update

I'm not 100% across all of the settings that used to be there (in particular the cache dir settings). I've really just grabbed what is the latest "template" from some other Silverstripe modules. 🤞

Updated yml config

• Manually tested that a project without --prefer-source can successfully run its own unit tests without these missing classes throwing an error (as described in 5.1: SapphireTestState config forces you to prefer-source for development/testing #138)

Practical test

• Manually test that project purges URLs when unpublished
• Manually test that project builds URLs when published
• Manually test that project rebuilds parent URLs when child is published or unpublished

[mfendeksilverstripe]

@chrispenny We're almost there, please add the following config to the phpcs.xml.dist just under the <description> tag.

    <file>src</file>
    <file>tests</file>

[mfendeksilverstripe]

Here is an example of phpcs file:

https://github.com/silverstripe/silverstripe-versioned-snapshots/blob/1/phpcs.xml.dist

[mfendeksilverstripe]

All ticks are green :D Nice one @chrispenny

[chrispenny]

Thank you for all of the help, @mfendeksilverstripe!

I've gone through my own regression tests for the project I'm working on, and I'm feeling pretty happy that the existing features that we rely on are still functioning.

[mfendeksilverstripe]

Hey @chrispenny , I noticed the following warning in the CI run:

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

This is coming from the PHPUnit 9 and we should be able to fix it by updating the phpunit.xml.dist. I think the XML file has now a different structure and naming conventions but you should be able to run the automatic update via phpunit --migrate-configuration command

[chrispenny]

Thanks, @mfendeksilverstripe!

I added allowed plugins (for composer v2), and ran the migration-configuration process.

[emteknetnz]

Could you replace this with https://github.com/silverstripe/gha-ci - we're replacing travis with this

You may need to do this in a separate PR that we merge before this one

[chrispenny]

I've raised #140

Can this happen after this PR?

[emteknetnz]

yeah after is fine

[emteknetnz]

Please remove the branch-alias from composer.json

I've created new 5 and 5.1 branches from master and retargetted this PR to 5

Please also create a follow up PR to remove the branch alias from the master branch

You'll want to check relevant projects that they're requiring this as ^5 rather than dev-master

[chrispenny]

I don't really understand what the consequences of those changes are, but they kinda sound like general house keeping? Does this all need to part of this PHP 8 upgrade PR?

[emteknetnz]

Preferably now .. we're targeting this at the 5 branch (which should have always existed), so if we keep the existing branch-alias's in the 5 and master branches there' a chance that requesting 5.x-dev will mistakenly fetch from the master branch when it shouldn't

[emteknetnz]

Happy with changes here