ENH Add generic types #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6/add-generics
branch
from
73d0f49 to
8ebfc7a
Compare
emteknetnz
requested changes
Jan 18, 2024
| @@ -36,7 +38,7 @@ public function getMyVirtualPages() | |||
| } | |||
|
|
|||
| /** | |||
| * @return array|SS_List | |||
| * @return iterable<SiteTree> | |||
There was a problem hiding this comment.
Also update StaticPublishingTrigger return type
| @@ -92,7 +94,7 @@ public function objectsToUpdate($context) | |||
| /** | |||
| * This method controls which caches will be purged | |||
| * | |||
| * @return array|SS_List | |||
| * @return iterable<SiteTree> | |||
There was a problem hiding this comment.
Also update StaticPublishingTrigger return type
GuySartorelli
force-pushed
the
pulls/6/add-generics
branch
from
8ebfc7a to
a1d0e65
Compare
emteknetnz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 for these generics to take effect.
Issue