ENH Add generic types

silverstripe · Jan 12, 2024 · d2f7171 · d2f7171
1 parent afbb9c4
commit d2f7171
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Controllers/TaxonomyDirectoryController.php b/src/Controllers/TaxonomyDirectoryController.php
@@ -17,6 +17,9 @@
  * Class TaxonomyDirectoryController
  *
  * Controller for returning a list of pages tagged with a specific Taxonomy Term
+ *
+ * @template T
+ * @extends PageController<Page>
  */
 class TaxonomyDirectoryController extends PageController
 {

diff --git a/src/TaxonomyTerm.php b/src/TaxonomyTerm.php
@@ -160,7 +160,6 @@ public function onBeforeDelete()
         parent::onBeforeDelete();
 
         foreach ($this->Children() as $term) {
-            /** @var TaxonomyTerm $term */
             $term->delete();
         }
     }
@@ -200,7 +199,6 @@ public function onAfterWrite()
 
         // Write the current term's type to all children
         foreach ($this->Children() as $term) {
-            /** @var TaxonomyTerm $term */
             $term->TypeID = $this->Type()->ID;
             $term->write();
         }