Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove webauthn module from behat tests #177

Closed

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 25, 2024

@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:33
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! That's a side-effect I hadn't considered.

We should probably add a dummy verification method into frameworktest so we can keep the "select a verification method" part in the behat test.

It would not be ideal if that functionality stopped working, since we should still allow multiple verification methods to be available even if only one of them is in a supported module.

@emteknetnz
Copy link
Member Author

If that's the case I think we should just keep webauthn as the "dummy verificaiton method"

Even though it's unsupported, the CMS 6 branch will still be around, so it can stay in require-dev

If you agree, just close this PR

@GuySartorelli
Copy link
Member

Sounds fine to me - it's a require-dev so that won't affect projects.
If it causes us problems in the future we can revisit the decision.

@GuySartorelli GuySartorelli deleted the pulls/6/remove-support branch November 27, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants