Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG TranslatableSiteConfigTest incorrectly bootstraps SiteConfig instances (minor) #224

Closed
tractorcow opened this issue Feb 9, 2016 · 1 comment
Closed

BUG TranslatableSiteConfigTest incorrectly bootstraps SiteConfig instances (minor) #224

tractorcow opened this issue Feb 9, 2016 · 1 comment

Comments

@tractorcow
Copy link
Contributor

This test bootstraps SiteConfig instaunces SiteConfig.en_US and SiteConfig.de_DE, however it fails to clear any pre-existing default siteconfig created. This causes $pageEn->getSiteConfig() to return the incorrect siteconfig instance under certain circumstances.
chillu added a commit to open-sausages/silverstripe-translatable that referenced this issue May 18, 2016
@chillu
Remove SiteConfig defaults from tests (fixes silverstripe#224)
cf043a0 
Causes TranslatableSiteConfigTest.testCanEditTranslatedRootPages to fail
when used in the CWP recipe (possibly because of subsites?).
tractorcow pushed a commit that referenced this issue May 19, 2016
Merge pull request #243 from open-sausages/pulls/siteconfig-defaults-…
61afbab 
…tests

Remove SiteConfig defaults from tests (fixes #224)
@tractorcow
Copy link
Contributor Author

Fixed with #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tractorcow