ENH Ensure TX_TOKEN environment variable is present #38
Conversation
emteknetnz
force-pushed
the
pulls/1/readme
branch
from
b28cbe4 to
265e6bc
Compare
|
Is this a new requirement? Is there a tx changelog somewhere that shows this being a new requirement? Or was this always required but we're just now adding a check for it? |
| $txToken = getenv('TX_TOKEN'); | ||
| if (!$txToken) { | ||
| $message = implode(' ', [ | ||
| 'Could not get a valid token from TX_TOKEN environment variable.', | ||
| 'Generate this at https://app.transifex.com/user/settings/api/ and add it to `~/.transifexrc` file by' . | ||
| ' manually running `tx push -s` on a supported repository and entering your token when prompted.' | ||
| ]); | ||
| throw new RuntimeException($message); | ||
| } |
There was a problem hiding this comment.
This looks like we're checking if an environment variable is present..... but not using it? Is this actually meant to check that ~/.transifexrc is set correctly? If so, check that instead.
There was a problem hiding this comment.
Seems like you actually need to pass it in. If you manually run tx push -s then ~/.transifexrc will be read, however in a PHP context there's the ~ directory presumably doesn't work. The tx binary (not our PHP program) will read TX_TOKEN so that it doesn't need to read from ~/.transifexrc
I'm not sure why this is now required. Possibly something's changed via an update in the tx binary since the last time this program was run? Though I don't see anything in their changelog or here
|
Closed in favour of #39 |
Issue silverstripe/.github#365
TX_TOKEN is used by the
txbinary which is called as a shell process. If it's not present then the program will fail.