API Ensure that duplications fail over to owned objects #106
Conversation
| $allowed = array_merge( | ||
| array_keys($this->owner->manyMany()), // Require mapping table duplications | ||
| array_keys($this->owner->belongsTo()), // Exclusive record must be duplicated | ||
| array_keys($this->owner->hasMany()) // Exclusive records should be duplicated |
There was a problem hiding this comment.
I'm not sure the has_manys should be duplicated. it's a relationship to an external record.
It's difficult because there's no one-size-fits-all approach here. Sometimes the has_many should be duplicated and other times it shouldn't and it really depends on the case...
With WidgetAreas for example, we leave it to the WidgetArea to duplicate the linked Widgets because in that instance it's what's needed (partly out of necessity because there's no interface for detaching a widget from one WidgetArea so changes and deletions propagate unexpectedly when using the interface.
But for ContentBlocks where they should be shared among pages, this behaviour is going to be undesired.
I think out of the box, we shouldn't be duplicating has_many relations...
There was a problem hiding this comment.
If it's owned (and thus necessary) and a has_many, then it's necessary to duplicate it.
You can work-around this by declaring a cascade_duplicates for that object, and then owns will no longer be used as the default. That's what we would do for widgets.
There was a problem hiding this comment.
But for ContentBlocks where they should be shared among pages, this behaviour is going to be undesired.
ContentBlocks don't own pages so it won't be a problem there.
There was a problem hiding this comment.
FYI at this stage we don't support many_many for content blocks
There was a problem hiding this comment.
Is many_many on the roadmap?
It always made sense to me to keep it unsupported for Elemental
There was a problem hiding this comment.
Support for it is in dnadesign/silverstripe-elemental-virtual (not SS Ltd supported) at the moment, but I don't know about commercial support for it longer term =)
Parent story #28
Ensures that, in the absence of cascade_duplications() versioned will use
ownsto infer duplications.