Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove GraphQL #456

Merged
merged 1 commit into from
Sep 2, 2024
Merged

API Remove GraphQL #456

merged 1 commit into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz changed the base branch from 2 to 3 July 30, 2024 06:30
@emteknetnz emteknetnz changed the title Pulls/3/remove graphql API Remove GraphQL Jul 30, 2024
@emteknetnz emteknetnz mentioned this pull request Jul 30, 2024
Closed
11 tasks
@emteknetnz emteknetnz force-pushed the pulls/3/remove-graphql branch 3 times, most recently from deaf5bb to e86a2d0 Compare August 19, 2024 05:38
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when everything's good to go

@emteknetnz emteknetnz force-pushed the pulls/3/remove-graphql branch 2 times, most recently from eca60e4 to 073cc43 Compare August 27, 2024 03:44
@emteknetnz emteknetnz force-pushed the pulls/3/remove-graphql branch from 073cc43 to 242479c Compare August 30, 2024 00:07
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@GuySartorelli GuySartorelli merged commit d38ebd1 into silverstripe:3 Sep 2, 2024
4 of 7 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/remove-graphql branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli