Skip to content

Commit

Permalink
Fix the overflow style for "Hide all checks" (go-gitea#27932)
Browse files Browse the repository at this point in the history
Fix go-gitea#27928

---------

Co-authored-by: silverwind <me@silverwind.io>
  • Loading branch information
wxiaoguang and silverwind committed Feb 20, 2024
1 parent d09dc18 commit 22d374d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
1 change: 1 addition & 0 deletions web_src/css/modules/tippy.css
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@

.tippy-box[data-theme="box-with-header"] .tippy-content {
background: var(--color-box-body);
border-radius: var(--border-radius);
padding: 0;
}

Expand Down
16 changes: 12 additions & 4 deletions web_src/css/repo.css
Original file line number Diff line number Diff line change
Expand Up @@ -3075,21 +3075,29 @@ tbody.commit-list {
}

.commit-status-header {
border: none !important; /* reset the default ".ui.attached.header" styles, to use the outer border */
margin: 0 !important;
/* reset the default ".ui.attached.header" styles, to use the outer border */
border: none !important;
/* add a bottom border to make sure the there is always a divider between the header and list when the list is scrolling */
border-bottom: 1px solid var(--color-secondary) !important;
/* use negative margin to avoid the newly added border conflict with the list's top border */
margin: 0 0 -1px !important;
}

.commit-status-list {
max-height: 195px; /* fit exactly 4 items */
max-height: 240px; /* fit exactly 6 items, commit-status-item.height * 6 */
overflow-x: hidden;
transition: max-height .2s;
}

.commit-status-item {
padding: 14px 10px !important;
height: 40px;
padding: 0 10px;
display: flex;
gap: 8px;
align-items: center;
}

.commit-status-item + .commit-status-item {
border-top: 1px solid var(--color-secondary);
}

Expand Down
2 changes: 0 additions & 2 deletions web_src/js/features/repo-issue-pr-status.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ export function initRepoPullRequestCommitStatus() {
const list = panel.querySelector('.commit-status-list');
btn.addEventListener('click', () => {
list.style.maxHeight = list.style.maxHeight ? '' : '0px'; // toggle
list.style.overflow = 'hidden'; // hide scrollbar when hiding
btn.textContent = btn.getAttribute(list.style.maxHeight ? 'data-show-all' : 'data-hide-all');
});
list.addEventListener('animationend', () => list.style.overflow = '');
}
}

0 comments on commit 22d374d

Please sign in to comment.