Rename CSS vars following DomainWidget
refactor
#1456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fourth and final step in addressing #1377. Closes #1382.
A lot of the CSS variables (currently prefixed with
--h5-domainSlider-
) relate to the slider itself (track, thumbs, etc.), which is now namedDomainSlider
and exported, so those don't change.Here are the variables that change:
--h5w-domainSlider-tooltip--bgColor
=>--h5w-domainWidget-popup--bgColor
DomainControls
is quite complex and the popup can be pinned open. It's more of a popover, really, but the term popup is a bit more generic and can apply to all toolbar popups (like the overflow menu). It's also consistent with the ARIA attributearia-haspopup
.--h5w-domainSlider-tooltip--bgColor
was actually applied to all toolbar "tooltips" inToolbar.module.css
. I introduce a new variable to fix this:--h5w-toolbar-popup--bgColor
and use it as default for--h5w-domainWidget-popup--bgColor
.--h5w-domainSlider-tooltip--colorAlt
=>--h5w-domainControls--colorAlt
--h5w-domainSlider-boundInput--shadowColor
=>--h5w-domainControls-boundInput--shadowColor
--h5w-domainSlider-boundInput-focus--shadowColor
=>--h5w-domainControls-boundInput-focus--shadowColor
--h5w-domainSlider-boundInput-editing--bgColor
=>--h5w-domainControls-boundInput-editing--bgColor
--h5w-domainSlider-boundInput-editing--borderColor
=>--h5w-domainControls-boundInput-editing--borderColor
--h5w-domainSlider-histogram--bgColor
=>--h5w-histogram--bgColor
--h5w-domainSlider-histogram--color
=>--h5w-histogram--color
--h5w-domainSlider-histogram--color
=>--h5w-histogram-marker--color