Let Overlay overflow canvas bounds by default
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
approved these changes
Aug 21, 2023
axelboc
force-pushed
the
fix-annoations
branch
from
851d010 to
6ccecfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1467, we now have a wrapper around the canvas (with the exact same size as the canvas) called
canvasWrapperthat, unliker3fRoot, does not hide overflow. This provides an opportunity for theOverlaycomponent, as consumers may want an overlay that allow its children to overflow past the canvas' bounds.This PR now renders
Overlaywith<Html overflowCanvas>, making the overflowing behaviour the default. Consumers may hide the overflow by simply passingstyle={{ overflow: 'hidden' }}.Note that this change affects
TooltipOverlayand thereforeTooltipMesh. However, since we useTooltipWithBoundsinternally, the tooltip never actually leaves the bounds of the canvas, so there is no visible change. In fact, this might open up new opportunities, as I believe @vallsv was after a tooltip and/or tooltip guides (i.e. cross hairs) that overflow past the canvas bounds.