Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement domain slider tooltip #521

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Implement domain slider tooltip #521

merged 3 commits into from
Feb 25, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Feb 25, 2021

Part of #510. The tooltip includes:

  • the currently applied min/max domain bounds;
  • the domain of the data;
  • toggles to autoscale the min/max bounds separately.

image

image

The tooltip displays values rounded to 3 significant digits, but the raw values are displayed on hover.

image

@axelboc
Copy link
Contributor Author

axelboc commented Feb 25, 2021

The overflow menu now shares the same design as the domain tooltip:

image

Note that the background is very slightly transparent to not completely hide the visualization underneath.

@axelboc axelboc force-pushed the slider-tooltip branch 2 times, most recently from 6b6d2af to dd80581 Compare February 25, 2021 09:21
@axelboc
Copy link
Contributor Author

axelboc commented Feb 25, 2021

/approve

@axelboc axelboc requested a review from loichuder February 25, 2021 09:27
@axelboc axelboc mentioned this pull request Feb 25, 2021
Closed
23 tasks
loichuder
loichuder reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the DomainSlider is way too complex: I had to read it several times and I still do not get it (and I already took my coffee ☕ )

This needs further discussion

src/h5web/toolbar/Toolbar.module.css Show resolved Hide resolved
src/h5web/vis-packs/core/heatmap/ColorBar.tsx Show resolved Hide resolved
src/styles/vars.css Show resolved Hide resolved
src/h5web/toolbar/controls/DomainSlider/DomainSlider.tsx Outdated Show resolved Hide resolved
@axelboc
Show tooltip on hover of domain slider with detailed info
ab307ff 
... and ability to autoscale min/max separately
@axelboc
Copy link
Contributor Author

axelboc commented Feb 25, 2021

/approve

@axelboc axelboc merged commit 74478b2 into main Feb 25, 2021
@axelboc axelboc deleted the slider-tooltip branch February 25, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder