Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show data domain on slider's track #530

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Show data domain on slider's track #530

merged 3 commits into from
Mar 4, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Mar 3, 2021

image

image

... and a little bit of transparency on hover, to see the dataDomain range:

image

@axelboc axelboc mentioned this pull request Mar 3, 2021
Closed
23 tasks
@axelboc axelboc requested a review from loichuder March 3, 2021 16:19
loichuder
loichuder requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the transparent thumbs, I think it is a great idea !

However, they seem to be placed so that the edge matches the track. I would prefer if the center matched the track.

The rest looks good !

src/h5web/toolbar/controls/DomainSlider/DomainSlider.module.css Show resolved Hide resolved
src/h5web/toolbar/controls/DomainSlider/Track.tsx Show resolved Hide resolved
@axelboc
Copy link
Contributor Author

axelboc commented Mar 4, 2021

/accept

@axelboc
Copy link
Contributor Author

axelboc commented Mar 4, 2021

/approve

@axelboc axelboc merged commit 7d92468 into main Mar 4, 2021
@axelboc axelboc deleted the data-track branch March 4, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder