Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Three to v0.117 to get WebGL v1 by default #548

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Downgrade Three to v0.117 to get WebGL v1 by default #548

merged 4 commits into from
Mar 9, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Mar 9, 2021 •
edited
Loading

Fix #547 - I had to replace RedFormat with AlphaFormat to resolve the issue of the heatmap being rendered with a solid color.

I've also added an error message for browsers that don't support ResizeObserver:

image

@axelboc axelboc mentioned this pull request Mar 9, 2021
Closed
@axelboc axelboc force-pushed the down-three branch 3 times, most recently from 77a418d to 31eb5ec Compare March 9, 2021 13:56
@axelboc axelboc requested a review from loichuder March 9, 2021 13:57
@axelboc axelboc marked this pull request as draft March 9, 2021 14:02
@axelboc axelboc marked this pull request as ready for review March 9, 2021 14:24
@axelboc
Copy link
Contributor Author

axelboc commented Mar 9, 2021

/approve

@axelboc axelboc merged commit 74f4f68 into main Mar 9, 2021
@axelboc axelboc deleted the down-three branch March 9, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heatmap vis does not display data
2 participants
@axelboc @loichuder