Implement editing of domain bounds #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Mar 11, 2021
loichuder
requested changes
Mar 11, 2021
axelboc
force-pushed
the
edit-domain
branch
2 times, most recently
from
bfd05f3 to
de2a06d
Compare
|
Before you merge, I noticed a small issue:
The tooltip disappears and do not appear again, even when moving thumbs. One must move the pointer away from the slider to make it reappear. |
Yeah, it's on purpose. You would only click this button to explicitly close the popup and cancel your edits. If you clicked and the popup stayed, it'd just feels confusing... wouldn't it? At least I thought it was when I first tried it, but that was before I had the input fields... |
|
Neh you're right, now with the input fields, the behaviour of keeping the tooltip open makes more sense. |
axelboc
force-pushed
the
edit-domain
branch
2 times, most recently
from
71debf7 to
7f7da3e
Compare
|
/approve |
Update Cypress reference snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screenshots for 😮, 😋 and 😍 ... (at least! 😏)