Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make errors sticky in domain tooltip #560

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Make errors sticky in domain tooltip #560

merged 1 commit into from
Mar 12, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Mar 12, 2021 •
edited
Loading

The error "unsticks" when the popup is closed because the BoundErrorMessage components are rendered conditionally based on the open state.

image

image

@axelboc axelboc requested a review from loichuder March 12, 2021 08:30
@axelboc axelboc mentioned this pull request Mar 12, 2021
Closed
23 tasks
loichuder
loichuder approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@axelboc axelboc merged commit 959d0f4 into main Mar 12, 2021
@axelboc axelboc deleted the sticky-errors branch March 12, 2021 09:38
@loichuder loichuder mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder