Encode query parameters in H5GroveProvider
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
force-pushed
the
encode-h5grove-params
branch
from
78d2c02 to
9bd0489
Compare
loichuder
force-pushed
the
encode-h5grove-params
branch
from
9bd0489 to
e631c03
Compare
loichuder
commented
Aug 5, 2021
axelboc
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix silx-kit/jupyterlab-h5web#45
Previously
The raw URL
/meta/?file=stack+.h5&path=/was unchanged.The
filearg gets interpreted asstack .h5byh5grove.Now
The URL
/meta/?file=stack+.h5&path=/gets encoded as/meta/?file=stack%2B.h5&path=%2F.The
filearg gets interpreted asstack+.h5byh5grove.