Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vis sizing feedback loop in some contexts #780

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Fix vis sizing feedback loop in some contexts #780

merged 1 commit into from
Aug 11, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Aug 11, 2021

This should fix the issue with long names on Jupyter Lab. The problem was actually caused by a feedback loop with the sizing of the visualizations. Taking the visualizations out of the flow with position: absolute seems to solve the issue.

axelboc
axelboc commented Aug 11, 2021
View reviewed changes
Copy link
Contributor Author

@axelboc axelboc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a technique we should keep in mind for when we measure the container in order to hard-code the size of the child.

src/h5web/vis-packs/core/matrix/MatrixVis.module.css Show resolved Hide resolved
@axelboc axelboc requested a review from loichuder August 11, 2021 10:25
@axelboc axelboc merged commit ca2ad04 into main Aug 11, 2021
@axelboc axelboc deleted the fix-long-names branch August 11, 2021 11:56
@loichuder loichuder mentioned this pull request Aug 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelboc @loichuder